stella
stella copied to clipboard
stella-emu
Wrong file type detection in ZIP files
In Linux, the 'readme' is shown as a dir folder, but 'entering' it plays it as if it's a ROM file. So as you say, it's just the detection that is off.
Confirmed; I see the problem. It considers a valid ROM as a file, and everything else a directory. The code needs to be reworked to mark a directory as such, and everything else a file. Working on it ...
I know now what the issue is, but it will have to wait until the FSNode API is simplified, when we move to std::filesystem in C++17.
Now that I'm not using the C++17 std::filesystem anymore (at least for the near future), I have to attack this problem from a different direction.
I'm wondering, why are we even showing non-ROMs at all in the ROM launcher? Even when we do show them, trying to launch them will result in a message saying "not a ROM', or some such. So if that's the case, why even show them? Hiding them completely from the user will render this issue moot.
@thrust26, I am now looking at this again. And I still wonder why we even need to show non-ROMs in the Stella launcher at all? All that will happen when attempting to run them is to get a message that it can't be done. If we only allow showing ROMs and directories, then the UI gets simpler, and this issue disappears.
To be clear, I'm wondering if the "Toggle file type filter" functionality is needed. Can you think of a valid use case for it?
As of now it only gives an overview of other existing files. And maybe it could be used to display e.g. text files (manuals) or images in the future. But generally it doesn't make much sense. It was always there, so I never wondered about it.
It is a problem?
Yes, it complicates fixing this very issue when dealing with ZIP files. So if it isn't necessary and we can't see a use case for it, I would like to remove it, and in the process make this issue moot.
I probably added this sometime in the (far) past, and no longer know why I did it :smiling_imp:
Fixed in https://github.com/stella-emu/stella/commit/49fb4d01bb819628d07f3716a1bf1f8afa650751.