kirby-plugin-custom-add-fields icon indicating copy to clipboard operation
kirby-plugin-custom-add-fields copied to clipboard

URL sync stops working with kirby 3.8.3

Open squareclouds opened this issue 2 years ago • 8 comments

hi everyone,

i updated today to kirby 3.8.3 and the plugin (and even pages/sections that dont use the plugin) stoped working, so overall the URL sync stops working. if i remove the plugin everything works fine again. any ideas?

kirby 3.8.3 php 8.1 plugin version 2.0.0

Bildschirm­foto 2022-12-15 um 10 16 35

squareclouds avatar Dec 15 '22 09:12 squareclouds

I noticed the same problem. php8.0

I wonder what could have changed

vivaneo avatar Dec 21 '22 10:12 vivaneo

We guess that this is the source of the problem: https://github.com/getkirby/kirby/issues/4953

afbora avatar Dec 21 '22 12:12 afbora

Thanks for reporting.

There seems to be few changes in kirby introducing regressions.

I will have a look into this in the next days.

steirico avatar Dec 23 '22 16:12 steirico

Give 3.0.0-beta1 a try, please.

Happy New Year!

steirico avatar Dec 31 '22 19:12 steirico

seems to be working now, but i only tested quite quickly. lets wait for someone else

squareclouds avatar Jan 04 '23 11:01 squareclouds

@steirico FYI: Some changes will be reverted on 3.8.4. Maybe you need to double check, before your new release: https://github.com/getkirby/kirby/pull/4982

afbora avatar Jan 04 '23 11:01 afbora

@afbora Thanks for the hint!

steirico avatar Jan 04 '23 16:01 steirico

IMHO, kirby 3.8.4 fixed the regression that also broke this plugin.

Please check if v2.0.0 of the plugin works as expect with kirby 3.8.4.

steirico avatar Jan 15 '23 17:01 steirico