steffest
Quit shortcut does not work when installed as an offline app
When DPaint-js is installed as an app, pressing cmd+q (or alt-f4 on windows,...) should exit the app, but it does nothing.
Note that the Quit DPaint.js entry menu works, but the shortcut does not.
This is because of this line:
https://github.com/steffest/DPaint-js/blob/bea976c324f8649f8fe2747ae8af37322db1d8b1/_script/ui/input.js#L311
Shouldn't this be run only if the event has been handled by DPaint.js?
Commenting it makes the cmd+q shortcut (as well as others, like cmd+,) work as expected.
well... sometimes it's not wanted to let the default browser behaviour go through. (For example Cmd-A should "select all" as a paint program; not "select all text" as the default browser behaviour is., Cmd-S should save the image, not the page, etc...) But as Cmd-Q currently is not in use for other things, we can (and should) let that through.
I think it depends on the context, for example, when the user is editing a text input/text area, Cmd-A should follow the default browser behaviour. For example:
That's why I was suggesting to prevent default behaviour only when the event is handler in DPaint.js.