Stefan Zweifel

Results 58 comments of Stefan Zweifel

@mortee This version of screeenly currently doesn't support manipulating cookies at all. However, the underlying library I use allows to pass cookies to Puppeteer. https://spatie.be/docs/browsershot/v2/miscellaneous-options/using-cookies A couple of years ago...

@aarondfrancis Would be awesome if you could take a look at this PR and merge / tag a new version. I think Laravel 11 is just around the corner. 👀

Thanks for reporting. I currently can't reproduce this issue. :/ Just to confirm, you've upgrade the Lambda function to use Node 20 and updated sidecar-browsershot to the latest version, right?...

@ZeroRin > btw does push have to be protected by the status check? Pushing with no change seems to be harmless. When I developed the Action, this made the most...

@ZeroRin Thanks for sharing the workflow. This makes understanding your problem much easier and I can see that this is a legitimate usage of the Action. My plan is to...

I'm closing this issue and will not implement this "split commit and push" feature, although I mentioned that I understand that it could be useful. I currently don't see a...

Thanks for the PR @Silver343. A new version has been tagged with this fix: https://github.com/stefanzweifel/sidecar-browsershot/releases/tag/v1.4.1.

I'm closing this issue for now, as we never really could figure out, why the workflow runs sporadicly fail. We also didn't get any new reports of this issue in...

I assume it's this workflow file, right? https://github.com/lukepighetti/mastodon_dart/blob/82b76b990435f9b3d8b69ec1778c686adedbc105/.github/workflows/main.yml#L4 You probably need to switch to listen to the `pull_request_target` event. Pushing commits in forks is a bit of a hassle. We...

@deitch Yeah, this sums it up pretty nicely. Technically kinda doable but you run into road blocks constantly, due to how GitHub wants GitHub Actions to work for forks.