crystal-redis icon indicating copy to clipboard operation
crystal-redis copied to clipboard

Support for Redis 5 Streams?

Open larskluge opened this issue 6 years ago • 7 comments

see https://redis.io/commands#stream

Would love to see streams supported. Is this on the roadmap any time soonish?

Thank you!

larskluge avatar Dec 04 '18 15:12 larskluge

Hi Lars, I am very busy at the moment. I think I might have time in February. PRs are welcome though.

stefanwille avatar Dec 10 '18 09:12 stefanwille

Hey Stefan, thanks for the note. No rush on my end, I would just love to play with it through Cristal :) I bet others are interested in this pretty cool new feature of Redis too. Thanks for you work!!

larskluge avatar Dec 12 '18 15:12 larskluge

I've added a PR #78 that starts the process of supporting streams. @larskluge please check it out and let me know what you think.

aemadrid avatar Jan 29 '19 01:01 aemadrid

Wow, beautiful—thank you, @aemadrid! Will play with it as soon as I find the time.

larskluge avatar Jan 31 '19 04:01 larskluge

@larskluge I've looked at implementing hashify for futures but I cannot quite get the hang of it. That affects how useful streams will be. For me living without pipeline/future support for streams is enough but that might not be what everyone else expects.

aemadrid avatar Feb 13 '19 23:02 aemadrid

I do very basic stuff just yet and am happy to have the support at all. Cool without pipeline/future support for a first version. On Wed 13. Feb 2019 at 18:45 Adrian Madrid [email protected] wrote:

@larskluge https://github.com/larskluge I've looked at implementing hashify for futures but I cannot quite get the hang of it. That affects how useful streams will be. For me living without pipeline/future support for streams is enough but that might not be what everyone else expects.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stefanwille/crystal-redis/issues/75#issuecomment-463422724, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHCYNvwKfoL2bmEqI8vrZNXd-eICKV2ks5vNKN8gaJpZM4ZA8JX .

larskluge avatar Feb 13 '19 23:02 larskluge

FYI: There is lower-level https://github.com/vladfaust/mini_redis which is Redis version independent, allowing streams in any mode.

vladfaust avatar Apr 23 '19 12:04 vladfaust