crystal-redis icon indicating copy to clipboard operation
crystal-redis copied to clipboard

Published 20 hours ago • verified publisher icon stefanwille

Slice values support

Open Hamdy opened this issue 5 years ago • 4 comments

Bases on comment :: https://github.com/stefanwille/crystal-redis/issues/47#issuecomment-349623431

Hamdy avatar Sep 03 '20 10:09 Hamdy

Hi, any progress on this?

aurimasniekis avatar Sep 18 '20 02:09 aurimasniekis

Support for binary data would be useful. When I tried with the PR, writing binary data worked. Yet reading will still result in everything being wrapped as String. At least, in the pub/sub API that I tried, I had to change the API from String to String | Bytes: https://github.com/Hamdy/crystal-redis/blob/22c24afe811f7fa119cf59e223c8e8dea832dd5f/src/redis/strategy/subscription_loop.cr#L54

Changing the API from String to String | Bytes is a breaking change. I wonder if there is a good solution.

philipp-classen avatar Oct 02 '20 14:10 philipp-classen

Any progress here? I just stumbled over this … being able to store binary data would really come in handy right now.

niko avatar Sep 07 '21 08:09 niko

This is a fine approach, but in order to be merged it would need to have some tests written around it so that it doesn't silently start to fail in the future.

robacarp avatar Sep 07 '21 18:09 robacarp