Stefan van der Walt
Stefan van der Walt
Has this been resolved? I thought I still saw this recently.
I think this is the kind of widget that works well on a project frontpage, like what NumPy does. For our documentation, I suggest we work on using JupyterLite to...
I'm going to close this in preference of future work done on Sphinx integrations with pyodide. See, e.g., https://blog.holoviz.org/panel_0.14.html#Sphinx-extension Thank you for opening this investigation, @DerThorsten!
The failure I observed was with setuptools 59.6.0, FWIW.
I can also reproduce with setuptools 65.3.0.
Our implementation looks incorrect to me. First, we calculate: ``` vals = len(np.unique(image)) ``` On a floating point image. That makes no sense! I think we should think more carefully...
@FirefoxMetzger We currently only utilize imread and imsave. Is there somewhere I can get an overview of the newly proposed API, without reading through the entire PR?
This is really neat! Thanks @moi90 for the implementation, and to all reviewers.
The change looks fine; I don't think we're exposed to big risk, but it won't hurt.
@grlee77 Do you think this is the optimal solution? Should we not try and broadcast mask to input array?