Stefan van der Walt
Stefan van der Walt
Thank you, and thank you for your contribution!
Just the one change left, then we should be good to go.
The code seems to be doing exactly what it should: the ellipse fit on *all* data is a bad fit, and the ransac fit is a better fit. You can...
Perhaps the confusion is why the input parameters and output parameters differ. I wonder if different parametrizations can result in similar ellipses?
OK, here's the long and short of it: (1) Noise is added do data, so we should not expect to recover the original model exactly. (2) The alpha parameter (rotation)...
Why, in the past, did we not use the actual center of the image? This feel incorrect, but I haven't delved into the matter deeply.
@lagru Perhaps a 2.0 fix, to change the center?
@zoccoler I left a naive comment here: https://github.com/scikit-image/scikit-image/pull/6493#issuecomment-1281394620 If you can respond to that, @lagru may be able to help get this over the line in time?
@zoccoler @lagru How close are we on this one?
I also see this on launch when another instance is already running. ``` $ Logseq 17:00:05.551 › open-url {:url "--allow-file-access-from-files"} uncaughtException TypeError [ERR_INVALID_URL]: Invalid URL at new NodeError (node:internal/errors:371:5) at...