build: explicit the arch for all platforms

[marier-nico]

Hello there!

I've noticed that the windows amd64 binary is actually built for arm (you can use this to verify yourself). I'm not a makefile expert, but I'm assuming the GOARCH = amd64 line at the top didn't work, so my proposed fix is to be explicit about the arch even for amd64.

I've tested my change, and it does generate binaries for the correct platforms 🚀

[stefansundin]

Ah, thanks, that's embarrassing. I downloaded the release artifacts and confirmed that it affects the Linux and macOS binaries too.

Could you also rename linux to linux_amd64, darwin to darwin_amd64, and windows to windows_amd64, so that everything is consistent?

Thanks for the fix!!

[marier-nico]

No worries, thanks for being responsive here though, it's awesome that we can fix it quickly! 😄

I've done the renaming and tested it, and the Mac binaries look good (though I haven't looked at Linux and Windows).

Glad I could help! 🎉

[marier-nico]

Awesome!

That's fair yeah, I think it would be mostly for the Windows users since there's not really a package manager there

[marier-nico]

Heya @stefansundin, sorry for the poke, but did you get a chance to test the change on all platforms?

[stefansundin]

Sorry for the delay, I'll do it now. :)

I also decided to just update the amd64 binaries in the last release.

[stefansundin]

Okay, done! The amd64 binaries in https://github.com/stefansundin/aws-rotate-key/releases/tag/v1.0.8 have been replaced.

Thanks again for the fix! 🥳

[marier-nico]

Awesome, thanks for that! And I'm glad I could help 😄