android-disable-direct-share icon indicating copy to clipboard operation
android-disable-direct-share copied to clipboard

Magisk module?

Open Madis0 opened this issue 6 years ago • 5 comments

Could this be made a Magisk module? That would allow for an easier install and remove the root requirement altogether.

Madis0 avatar Nov 02 '18 05:11 Madis0

I haven't really used Magisk so I have no idea, but I will give it a try. Thanks for the idea!

stefansundin avatar Nov 02 '18 16:11 stefansundin

I made an attempt to create my own module.. but I can't get it to work. I think magisk is mostly intended to replace stuff in /system, but since I'm trying to alter /data, I'm not sure how to do it exactly.

If anyone else can figure it out, please write a comment here. Feel free to submit it to the magisk directory too.

stefansundin avatar Nov 12 '18 02:11 stefansundin

Here is the Magisk module: https://github.com/AndroPlus-org/magisk-module-direct-share-disabler

AndroPlus-org avatar Dec 22 '19 06:12 AndroPlus-org

Nice. I can update the README with a link to that.

Will it work on Android 10? I'm guessing the answer is No since it seems to be using the same method and file, just injecting it with Magisk.

stefansundin avatar Dec 22 '19 21:12 stefansundin

Unfortunately it doesn't work on Android 10...

AndroPlus-org avatar Dec 22 '19 23:12 AndroPlus-org