dockprom icon indicating copy to clipboard operation
dockprom copied to clipboard

Published 20 hours ago • verified publisher icon stefanprodan

Added dcgm exporter

Open maingoh opened this issue 4 years ago • 4 comments

related to #148

maingoh avatar Mar 09 '20 18:03 maingoh

While this is a great contribution, I'm not entirely sure how useful this would be to include as a default position.

Many dockprom installations may be headless and not even have an nvidia based card with all the respective drivers/pre-reqs.

I'm going to defer to @stefanprodan for his opinion on this.

nightah avatar Mar 10 '20 03:03 nightah

I agree, this was more an example for those looking to add dcgm. However I can try to make it optional, if you think this is possible ? (i am not so much familiar prometheus). It can be a python script that would generate the final docker-compose depending on some options ?

maingoh avatar Mar 10 '20 10:03 maingoh

I think the best way to make it optional would be just to document it in the README, that way if someone wants to add it in, all the information is there.

nightah avatar Mar 12 '20 13:03 nightah

I agree with @nightah I think the NVIDIA exporter could be documented in a separate markdown file and linked from the readme.

stefanprodan avatar Mar 12 '20 17:03 stefanprodan