Stefano Sala

Results 11 comments of Stefano Sala

@masiulis amazing, thanks! Is there any way we can collaborate / help?

Hi there, we don't have anything like this, yet, unfortunately.

That would be amazing! 🔝

Hi @richardkeller411! Thanks for the PR and sorry for the delay :) Could you please only push what you're really changing and not touching other lines? Aka please don't change...

I'm for 1. too, but we could at least check if the methods we need are in the passed client object and if they return promises.

A clarification on this topic would be really useful! Thanks :)

@Eomm I've gone a bit into the rabbit hole and I can't seem to find an elegant solution to this issue. `deepmerge` will try to clone the `EventEmitter` from Pino...

Thanks, what type of objects do you think we should clone? My guess would be to clone only plain objects (`Object.getPrototypeOf(value) === Object.prototype`)?

Actually, that callback isn't being called in this case because it goes on [this line](https://github.com/fastify/deepmerge/blob/66ec946dac3448f83e15c70de5103a4cd7379aee/index.js#L134), where it is directly being merged into target. In my example above, `target` is a...

Happy to see a progress here, thanks @alcuadrado :)