dirstalk icon indicating copy to clipboard operation
dirstalk copied to clipboard

add assume-404-regex flag

Open vladertel opened this issue 1 year ago • 7 comments

Add ability to mark server response as 404 when it responds with 200 and "Not found" message

vladertel avatar Nov 26 '23 12:11 vladertel

ohhh, the PR got a little bit large since my IDE autoformatted several files. I hope you don't mind

vladertel avatar Nov 26 '23 12:11 vladertel

Hey! thanks for the PR, the makefile contains a command to format the code, this should bring the files you changed without wanting to back to normal.

I like the change but I'd appreciate if you took the time to make it more generic

rather than having a flag specific for 404 like

--assume-404-regex "404: page .* was not "

what do you think about changing it so it can be used with any status code?

example

--assume-status-code=404 --assume-regex="404: page .* was not "

stefanoj3 avatar Dec 14 '23 13:12 stefanoj3

@stefanoj3 done

vladertel avatar Dec 24 '23 22:12 vladertel

@stefanoj3 ping. could you also make a new release and update one in homebrew?

vladertel avatar Feb 08 '24 10:02 vladertel

@stefanoj3 ping

vladertel avatar Mar 22 '24 08:03 vladertel

Hey, sorry for the late comeback @vladertel in the next days I will review and merge if there are no issues.

Thanks for the time spent on this contribution so far.

stefanoj3 avatar May 16 '24 12:05 stefanoj3

That's a feature I've wanted in this tool for a long time @vladertel thanks for this PR 👍.

cli-ish avatar May 31 '24 16:05 cli-ish