Unhelpful error when running action

[daniel-vc]

Hi, I'm trying to use your linting action but even though i've followed your set up steps, and running eslint locally, I get the below message. Any ideas?

[stefanoeb]

hey @daniel-vc

Looks like it's a problem with your tests themselves regarding promise chaining.

Just to clarify: does it reproduce locally?

[noftaly]

Hi, I have the same issue, and no, it is only in the actions. I don't have those messages locally. For me, it comes from your action! You can see it right here: https://github.com/Skript-MC/Swan/runs/533285405?check_suite_focus=true

[gslama-akqa]

Hi there, I can confirm I'm getting the same warning.

[abmusse]

@stefanoeb

I also experienced this issue and found that it is caused by this issue https://npm.community/t/npm-ci-produces-a-tonn-of-excess-warnings-on-install/3261.

This can be fixed by upgrading the nodejs image used in the docker file. I tested using nodejs 12 (current LTS) and this issue went away. I Opened up #10 to help resolve the issue.

[rdzak]

I had to remove this action from the workflow due to the same error. I'll be watching this issue to verify it's fixed with proposed solution (node upgrade)

[stefanoeb]

I would actually recommend running ESLint without this action, because out of the box the ubuntu runtime of Github Action has everything we need now, like so:

name: CI
on: push
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - name: Install modules
      run: yarn
    - name: Lint
      run: eslint .

[stefanoeb]

Now in the end, all this action is doing is running eslint inside a docker container. I'd say that we would be better off just not using docker at all and run eslint inside the normal runtime (which I hope is regularly updated)