grepWin icon indicating copy to clipboard operation
grepWin copied to clipboard

Replace does nothing with binary files

Open 7kt4 opened this issue 1 year ago • 1 comments

Replace text in binary files does nothing, it just flashes for a second and does not touch the files

7kt4 avatar Mar 19 '24 03:03 7kt4

Try the latest Artifacts from https://github.com/stefankueng/grepWin/actions. I had improved it.

lifenjoiner avatar Mar 20 '24 05:03 lifenjoiner

Try the latest Artifacts from https://github.com/stefankueng/grepWin/actions. I had improved it.

This version corrupts the binary files

7kt4 avatar Mar 23 '24 18:03 7kt4

Prove it.

To be honest, binary files vary. It is highly likely that they are not correctly decoded, BTW. You should know that, and don't expect it works in the same way like text files. Only do it when you know exactly what you are doing, and always make backups.

lifenjoiner avatar Mar 24 '24 00:03 lifenjoiner

Prove it.

To be honest, binary files vary. It is highly likely that they are not correctly decoded, BTW. You should know that, and don't expect it works in the same way like text files. Only do it when you know exactly what you are doing, and always make backups.

It removes two bytes from the file for some reason, hence corrupting it

https://github.com/stefankueng/grepWin/assets/84914212/f04a2a5c-e227-4a99-9247-2b1ae4870ec2

7kt4 avatar Mar 24 '24 01:03 7kt4

Thanks for your feedback! Should be fixed by https://github.com/stefankueng/grepWin/commit/dc586b1fcea22af8ed72999ff3ebc0ec5534dfb3. Try the latest.

lifenjoiner avatar Mar 24 '24 11:03 lifenjoiner