python-json-patch icon indicating copy to clipboard operation
python-json-patch copied to clipboard

Moved the metadata into `setup.cfg`.

Open KOLANICH opened this issue 3 years ago • 6 comments

Added pyproject.toml. Version is now fetched and populated automatically from git tags using setuptools_scm. Metadata stored in source files is fetched using read_version. Got rid of raw scripts, using console_scripts entry point since now.

KOLANICH avatar Jan 02 '22 14:01 KOLANICH

Coverage Status

Coverage decreased (-0.1%) to 65.69% when pulling ab4f641af43412d3cc609abed35d08cc761efec2 on KOLANICH-libs:setup.cfg into 714df3c2102630a80691c4248b0b7babda5d128b on stefankoegl:master.

coveralls avatar Jan 02 '22 14:01 coveralls

Coverage Status

Coverage decreased (-5.5%) to 60.338% when pulling 98155d3ce8e22e802b5a47d68092fd17b218eac1 on KOLANICH-libs:setup.cfg into 714df3c2102630a80691c4248b0b7babda5d128b on stefankoegl:master.

coveralls avatar Jan 02 '22 14:01 coveralls

Hi! Thanks for your contribution!

The build fails for Python 2.7, which is still supported by jsonpatch. Can you have a look?

stefankoegl avatar Jan 16 '22 20:01 stefankoegl

Should we just drop 2.7? In my own projects I have never supported python 2. Given that I am in python since 2013 ... and given that 2 has been dropped by PSF, I guess it may make sense to drop it too.

KOLANICH avatar Jan 16 '22 20:01 KOLANICH

I've opened the discussion about dropping Python 2.7 support at #140.

stefankoegl avatar Jan 18 '22 15:01 stefankoegl

I was going to make these same changes. Almost exactly like you made them.

cardoso-neto avatar Aug 06 '22 03:08 cardoso-neto