grunt-phantomas
grunt-phantomas copied to clipboard
Make it possible to check multiple routes in index
Follow up of #28 requested by @pgilad.
@pgilad
Just thought about that. What about showing multiple routes in one graph? Seems to be better to me, then having tabs?
what about providing checkboxes to enable/disable the display multiple routes in the graphs?
Jep. Good idea! :+1:
any clear specs on that?
as far as i could understand:
- [x] create an option to test several routes/urls
- [x] display those routes on the same graphs with option to toggle them on/off
anything else?
i could give it a try, just need to know the specs ;-)
Config should accept two types for url String and Array.
options : {
indexPath : './phantomas/',
options : {},
url : 'http://gruntjs.com/'
}
&
options : {
indexPath : './phantomas/',
options : {},
url : ['http://gruntjs.com/', '...', '... ]
}
:+1:
will give it a try later on
this, however, will be a bit of a breaking change - filename-wise or data-structure-wise
- filename would follow a pattern of
[url-slug]-[timestamp].json - data-structure could contain the
urlprop
which one would be preferred?
Would prefer to stick with [timestamp].json.
:+1: for:
data-structure could contain the url prop
ok, but now - how do we split the results across different urls?
on the top-level, like
{
"example.com" : {
"results" : { ... },
"gzipRequests" : { ... },
...
},
"example.com/foo" : {
"results" : { ... },
"gzipRequests" : { ... },
...
}
}
or on the individual prop level, like
{
"results" : {
"example.com" : { ... },
"example.com/foo" : { ... },
...
},
"gzipRequests" : {
"example.com" : { ... },
"example.com/foo" : { ... },
...
},
...
}
can we sum it up @ the top of this issue please? just so we have a clear specs in one place, not split across 100 comments :-)
Both fine for me. ;) But tend to like second version more.
:+1: