Stefan Drissen

fur format

1

I thought it would be fun to write an E-Tracker module (SAM Coupé) to furnace converter. However... while I used to enjoy hacking the bits out of binary files back...

PDSOE: replacing r-code

9

This is not directly a PCT problem, but is IMHO very interesting for PCT users. There are two place in PDSOE where r-code built by PDSOE seems to be needed:...

Unused buffer

1

```` define temp-table tt no-undo field hb as handle . procedure foo: define parameter buffer bu for tt. message bu.hb:buffer-field( "bar" ). end procedure. ````

Conflicting rules for static and dynamic finds

2

A static find **without** no-error: ```` find customer. ```` Triggers the findnoerror rule which warns that if no record can be found a run-time error will occur. A dynamic find...

WHERE clause contains reference to... Call to BUFFER-FIELD

2

The following code snippet flags ``WHERE clause contains reference to... Call to BUFFER-FIELD`` ```` DEFINE TEMP-TABLE ttfoo NO-UNDO FIELD cc AS CHARACTER . DEFINE VARIABLE hb AS HANDLE NO-UNDO. hb...

```` DEFINE VARIABLE cfoo AS CHARACTER NO-UNDO VIEW-AS SELECTION-LIST INNER-LINES 5 INNER-CHARS 60. DEFINE FRAME fr cfoo . ENABLE ALL WITH FRAME fr. cfoo:ADD-FIRST( "foo":u ). cfoo:ADD-LAST( "bar":u ). DO...

More dead code

1

While the compiler is able to flag: ```` return false. message 'never executed'. ```` I just ran into (oversimplified): ```` if not lvalue then return false. if not lvalue then...

Variable is read but never assigned not triggered when variable assigned /after/ read

2

The 'variable is read but never assigned' rule does not detect the following smell: ```` DEFINE VARIABLE foo AS LOGICAL NO-UNDO. IF foo THEN MESSAGE "bar":u. ELSE foo = TRUE....

Variable usage memptr

2

The following code is falsely flagged in two places: ```` define variable mp as memptr no-undo. // read but never assigned run bar ( mp ). message get-long( mp, 1...

State not reset

3

From a real issue, a version of this was in a session super procedure: ``` def var p_lerror as logical no-undo. function getError returns logical (): return p_lerror. end function....