sitemap-plugin icon indicating copy to clipboard operation
sitemap-plugin copied to clipboard

Published 20 hours ago • verified publisher icon stefandoorn

Add support for images in sitemap

Open stefandoorn opened this issue 6 years ago • 7 comments

#51 & #61

  • [x] Make sure paths are browser URL's (cache)
  • [x] Proper DI in ProductToImageSitemapArrayConverter
  • [ ] Make image support optional (default = on)
  • [ ] Support localisation (optional)
  • [x] Support product provider
  • [ ] Support taxon provider
  • [ ] Add specs for ProductImagesToSitemapImagesCollectionGenerator

stefandoorn avatar Jan 22 '19 21:01 stefandoorn

@Roshyo Would you be able to help on moving this issue further to completeness?

stefandoorn avatar Jul 01 '19 13:07 stefandoorn

Hi, I'll try to find some time to do so.

Roshyo avatar Jul 08 '19 09:07 Roshyo

@stefandoorn what do you mean by Support taxon provider ?

Roshyo avatar Aug 01 '19 10:08 Roshyo

To have the taxon provider also inject it's images, currently only the product provider is having that supported.

stefandoorn avatar Aug 07 '19 19:08 stefandoorn

Oh okay. I'll do another PR for this if you're okay.

Maybe you want to review this one ?

It fixes Make image support optional (default = on) and Add specs for ProductImagesToSitemapImagesCollectionGenerator

Roshyo avatar Aug 07 '19 19:08 Roshyo

Support taxon provider also done

Roshyo avatar Aug 13 '19 15:08 Roshyo

@stefandoorn can you have a look ?

Roshyo avatar Aug 15 '19 13:08 Roshyo