sitemap-plugin icon indicating copy to clipboard operation
sitemap-plugin copied to clipboard

update recipes

Open Snowbaha opened this issue 4 years ago • 3 comments

Hello,

You should update the recipies with the good config file name :)

I stuck for 1 hour to undersntand it is missing the "a" in config.yaml

https://github.com/symfony/recipes-contrib/edit/master/stefandoorn/sitemap-plugin/1.0/config/packages/sitemap_plugin.yaml

AND Update Readme with good command image

It is

$ php bin/console sylius:sitemap:generate

not with "-index" in the alpha5 for me.

Snowbaha avatar Jun 22 '21 07:06 Snowbaha

Are you able to submit a PR for both things?

I think the recipe links to version 1.0, and the file extension got changed in v2.

stefandoorn avatar Jun 28 '21 11:06 stefandoorn

I don't really know how it works. I wanted to change but I think it can break the 1.* so maybe when you will do the v2 stable ?

Snowbaha avatar Jun 28 '21 11:06 Snowbaha

I actually have no clue myself either, someone else provided that PR to Symfony. @Margauxfeslard could you be of help here to us?

stefandoorn avatar Jul 16 '21 11:07 stefandoorn

@vvasiloi merged it I see :-)

stefandoorn avatar Oct 25 '22 10:10 stefandoorn

Thanks @ehibes !

stefandoorn avatar Oct 25 '22 10:10 stefandoorn