detect-missing-adblocker icon indicating copy to clipboard operation
detect-missing-adblocker copied to clipboard

Overengineering part uno

Open tkgroot opened this issue 2 years ago • 2 comments

such a good project deserves to be over-engineered.

The commit messages give a clear indication of what have been done. Why I did what I did:

  • the idea is simple. you don't want to manually manage your versions. This is my first attempt to streamline your release process. However since I do not know how wordpress plugins are published yet, I made some assumptions.
  • commitlint and conventional-commits will be a bit of a burden at first, however it lets you automatically infer the new release version (I want to update this further to fully automate your release process for your wordpress plugin. Therefore I just need a bit more research).
  • Further I improved the code style and formatting (stylelint is a bit over the top for so little styles)
  • updated the node version to support all dependencies
  • executed npm audit to resolve all vulnerabilities
  • added more meta data to the package.json (this comes in handy later when you publish your package as it will become the single source of truth).

I understand that this is shooting sparrows with a cannon or using a sledgehammer to crack a nut. That's the whole point. If you find this useful let me know. No hard feelings if you do not like it. I had fun doing this.

tkgroot avatar Sep 03 '23 10:09 tkgroot

Hi @tkgroot , thank you so much for all your work! I've been pretty busy, but will go through the changes over the next few days.

stefanbohacek avatar Sep 17 '23 22:09 stefanbohacek

Sure, take your time. let me know if you have questions. I'm more than happy to answer them

tkgroot avatar Sep 18 '23 18:09 tkgroot