Stefan Bohacek

Results 76 comments of Stefan Bohacek

@cybeardjm It does make sense to limit loading the JS/CSS only when an embed is on the page, good call. The tricky part here is that you can really embed...

Sure, that makes sense. On a side note, I will add that the plugin still provides a [huge performance boost](https://stefanbohacek.com/project/wordpress-plugin-for-fediverse-embeds/#performance) compared to the default embed method, at least for Mastodon....

@cybeardjm Yes, adding an option to customize the behavior and let the user decide makes a lot of sense. Thank you for the suggestion!

Fixed in https://github.com/stefanbohacek/fediverse-embeds-wordpress-plugin/commit/932f2ab0393ed750405334c073b71430439bff1a and https://github.com/stefanbohacek/fediverse-embeds-wordpress-plugin/commit/91ff2db2497cd5e5f5024682107d287924697006.

@devxan Thank you for the suggestion! Please note that due to there being 16 language versions of the site, it might take some time to coordinate all the translation work.

@wakest That is very interesting, I'll look into it! Thank you for opening an issue for this!

@cheeaun Would you be interested in adding a class to the `blockquote` element that would help identify a Phanpy embed?

@cheeaun One of the [two hard problems](https://skeptics.stackexchange.com/questions/19836/has-phil-karlton-ever-said-there-are-only-two-hard-things-in-computer-science) in computer science! Mastodon uses `mastodon-embed`, so perhaps `phanpy-embed` will do?

Fair point! Maybe you could do both the class and a data attribute? I think it makes sense to follow Mastodon's example and identify the source of the embed, plus...

Sorry, to clarify, by following Mastodon's example I meant you could include `phanpy-embed` to identify this element as an embed code retrieved via Phanpy, not to use the actual `mastodon-embed`...