stefan11111
stefan11111
I have tried to fix this too, but I couldn't figure out how. Do you have an idea how to write a patch that fixes it? https://github.com/mcpcpc/kirc/issues/134
@mcpcpc I also made a patch to add support for sending files via DCC. It works, but it's not in it's final form, as I'd like to clean up the...
@mcpcpc The DCC SEND code is mostly done. I wonder if I should also do: ``` if (dcc) { signal(SIGPIPE, SIG_IGN); } ``` So that the program doesn't crash if...
@mcpcpc I ended up fixing this too: https://github.com/mcpcpc/kirc/issues/134 I have 2 patches for it. patch1: ``` diff --git a/kirc.c b/kirc.c index a4ebb69..d1cfaea 100644 --- a/kirc.c +++ b/kirc.c @@ -197,6 +197,10...
I ended up taking the first approach(with a different patch) and also treating '\031' as space, which was another character which would break the message buffer.
@mcpcpc sure. I plan to look as some more things. I'll let you know when I'm done.
@mcpcpc I think I'm done with the changes.
I vote for trying stdout too, but not killing the server on failure.
@GermanAizek Can this be closed, since the pr was merged?
> > [@GermanAizek](https://github.com/GermanAizek) Can this be closed, since the pr was merged? > > well, I found out that the second poc payload caused this problem more often in the...