Stefan Korn

@dafeder : I changed the place of injecting maxlength from StringHelper to WidgetRouter. Injecting in StringHelper is problematic, because the WidgetRouter might change the type "textfield" to something else, i....

Hm, this is way more complex than I have thought. ArrayHelper and ObjectHelper together with the "add one" button do their own thing in some way. I'm now tending to...

Yes, maybe some refactoring would help to solve it in the JSON Form Widget. Probably it will have to happen in the StringHelper, but then in the WidgetRouter one would...

@dafeder : There is another issue that arises in this context, but not related to textfields maxlength directy. The [base field filePath of ResourceMapping entity](https://github.com/GetDKAN/dkan/blob/2.x/modules/metastore/src/Entity/ResourceMapping.php#L75) is defined as a string...

@dafeder : Have you read the description in #4179 ? I cannot reproduce this on plain DKANv2, only with our customized schema. But it should not return an empty array...

@dafeder : I am attaching an example of dataset.json which can produce the issue. There is new property "dctconformsto" in the distribution (as an array of objects). The steps to...

@dafeder . i suppose this error was because the branch was out of sync with current head. I have synced with latest changes from head now. fix for #4178 was...

@dafeder : Hmm, at this moment I can also not reproduce the original issue we had. I suppose by providing the dataset.json that produces an error, I was somehow let...

I have created a module [DKAN reference fix](https://www.drupal.org/project/dkan_reference_fix) that should fix this issue. This module just needs to be enabled and it has to be taken care that the patch...

okay, codeclimate says it all ;-) > \Drupal calls should be avoided in classes, use dependency injection instead Will take a look into this.