Stefan Kroboth

Results 85 comments of Stefan Kroboth

> thanks for the feedback! Sorry for being slow to respond, but I'm doing this as a little weekend side project :) I will go through your review suggestions as...

I just merged a [PR](https://github.com/argmin-rs/argmin/pull/180) in `argmin` which adds a feature that allows users to remove the `serde` dependency. This isn't released yet though and unfortunately I can't make any...

@YuhanLiin thanks for your reviews! However, I wasn't done yet with the first review ;) I'll request another one when I'm ready. Like I said in the edit of my...

I managed to fix the issue, but I'm not unsure if the fix is a breaking change. To be on the safe side I'll probably release 0.7 soon, hopefully in...

Hi @VolodymyrOrlov , this PR is really far ahead and I'd really like to include it in the next release. There only seem to be one remaining issue regarding the...

Rereading my previous message again I realized that it may have come across as pushy. I apologize if it made that impression, this was certainly not my intention. Thanks for...

Hi @Trombach, Is there any news regarding this PR? Feel free to get in touch if there is anything I can help you with :)

This only works for the nalgebra backend, and not for `ndarray` and `vec`. The following does **NOT** compile: ndarray: ```rust fn optimize_generic5(cost: T, init_param: Array1) -> Array1 where F: ArgminFloat...

A potential reason for the difference between the backends could be the way the math traits are implemented on the data types. For instance, comparing the `ArgminSignum` implementation for `nalgebra`:...

I rebased this commit and removed the ndarray ArgminMinMax implementation in favor of the one which was added to main since this PR was opened. I also implemented the trait...