vscode-shader
vscode-shader copied to clipboard
stef-levesque
Potential visual regression in glsl grammar
Not sure if this was intended or not, but the visuals changed fairly dramatically in certain aspects (include directives, function names, probably more)
Before:
After:
Hm, the recent refresh of the GLSL grammar removed some of our improvements, indeed. Will fix that.
There is arguably pros and cons to the new GLSL grammar. I agree the #include tag should be fix, and the function parameter. But on the other side, we now have a distinction between data-type constructors (blue), built-in functions (yellow) and user functions (white).
We don't have code analysis on GLSL, so I like the distinction between built-in and regular functions. I wouldn't like to have them marked as generic keyword. Not sure what would be the best approach here.
I think reverting the color of the user functions would make sense. This would be in-line with what other languages do, in my case functions having a blue color as you can see from screenie #1. Giving built-in functions a distinction seems like a good idea though for sure, fully on-board with that :slightly_smiling_face:
