france.code-civil icon indicating copy to clipboard operation
france.code-civil copied to clipboard

Improve text in README.md

Open jankeromnes opened this issue 11 years ago • 13 comments

Thank you for doing this! I've been toying with the idea for a while, so I'm extremely happy that this now exists.

There were a few minor typos and confusing expressions in the README, so I fixed them.

jankeromnes avatar Mar 31 '15 10:03 jankeromnes

verisonnement => versionnement

pyrou avatar Mar 31 '15 10:03 pyrou

Thanks for the quick catch @pyrou! Fixed, along with a few "celà".

jankeromnes avatar Mar 31 '15 10:03 jankeromnes

You should rebase your PR, as it's a duplicate of https://github.com/steeve/france.code-civil/pull/1 (which was merged recently).

emerick42 avatar Mar 31 '15 11:03 emerick42

i feel bad for all the typos, but i was writing with my qwerty keyboard falling asleep at 3am haha

thanks guys, this is what open source is about :)

steeve avatar Mar 31 '15 11:03 steeve

@steeve Rebased on top of the new changes. Includes the same fixes as pull request #16, plus a few others.

jankeromnes avatar Mar 31 '15 15:03 jankeromnes

Please see #23 and #24 for more.

EHadoux avatar Apr 02 '15 08:04 EHadoux

My these get out-dated quickly. I'll give up and let the more eager take over :)

jankeromnes avatar Apr 02 '15 08:04 jankeromnes

No, no, I guess all those PR (this one #9, #16, #23 and #24) do not have the same fixes. They all need to be merged.

EHadoux avatar Apr 02 '15 08:04 EHadoux

@EHadoux My pull request is already stale because others have been merged first, and I'm too lazy to rebase :) feel free to steal my changes and rebase them into your commits though!

jankeromnes avatar Apr 02 '15 08:04 jankeromnes

The part about the rewrite using french words would have been interesting (I'm not sure it has already been changed elsewhere).

emerick42 avatar Apr 02 '15 08:04 emerick42

Ok, I'll re-open this then. But please feel free to use my changes elsewhere if this doesn't get merged, I don't really care about attribution :)

jankeromnes avatar Apr 02 '15 08:04 jankeromnes

Rebased on top of new HEAD.

jankeromnes avatar Apr 02 '15 08:04 jankeromnes

I think we should try to merge it once @steeve has merged other PRs about modifying the readme (or even before, it doesn't impact that much).

emerick42 avatar Apr 02 '15 12:04 emerick42