steeling

Results 111 comments of steeling
trafficstars

This will likely be necessary when/if we implement gradual mTLS across a mesh

FYI This may be splittable into further sub tasks as well

> Currently, the logic for constructing traffic policies is entirely handled by the mesh cataloger. For instance, the inbound mesh traffic policy is built in the GetInboundMeshTrafficPolicy method in inbound_traffic_policies.go,...

The MeshCatalog will be analogous to the response.go's NewResponse method. It will make queries to the compute.Interface, and set fields on a builder object, finally calling `Build`. Except instead of...

> Member Great question! Maybe, it's quite possible it would be cleaner to do it that way. I'd say that's up to whoever implements it :)

It looks like if `enableReconciler` is set to true it can lead to issues as well

expanding on my last comment: the reconciler attempts to keep things at the current version. If 2 OSM versions are up for a brief period of time, one which has...

actually patchCRDs is not the issue (we can verify that the new CRD gets created), but that immediately upon startup the bootstrap attempts to create the new meshconfig version (via...

Spoke offline, but for posterity, k8s calls this out here https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#writing-reading-and-updating-versioned-customresourcedefinition-objects So explicitly, the conversion does not happen when writing a CRD. More definitively, even if it did, the conversion...

To clarify a bit the points above: our current webhooks do nothing that the implicit conversion wouldn't do anyways, when `strategy` is set to `None`. Further: 1. Currently, the conversion...