Stefán Jökull Sigurðarson

Results 79 comments of Stefán Jökull Sigurðarson

ActivitySource should be the correct one to look at. I spiked this myself a few months back, time to revisit :) What would people consider good activities/counters to start with?...

@cijothomas Yep. I'm aware of the differences. We're looking to integrate both the new dotnet counters (for metrics) as well as support for Activity Tracing. Tracing will come later since...

> @stebet Thanks! > To instrument, you won't need OpenTelemetry dependency, right? You can use 5.0.0 of DiagnosticSource. > (Also OpenTelemetry will release 1.0.0 in > Please also check the...

Let's make a distinction between activities and counters since they aren't the same thing (although related). There are Event counters in NS2.0 targets, but it's a lot less capable. It'd...

I already have a working type in the async branch, which uses/reuses ValueTasks from a pooled resource. You can use that as a reference as well. It also uses locking...

> I can't yet request formal reviews, but I would like to start having a discussion about these changes as they should mark the direction of 8.0. > @michaelklishin @stebet...

Also on that note, if breaking changes are to be made in 7.0.0 do you want that on a separate branch or create a separate 6.X branch for maintenance work...

> Maybe we need Async versions of all RPC interactions? That's something I'd be very much open and willing to submit a PR for. I already have a PR ready...

Yeah, I thought about the same thing. It'd make sense to have the connection just take care of the handshake, socket handling,(de)serializing frames, channel creation and forwarding commands with channel...

My biggest reason for going with NS2.1 was the "Span"ification of the BCL. I can certainly look into the amount of work required to get my Async-branch to compile under...