bluejay
bluejay copied to clipboard
Make WriteCharacteristic fail if types mismatch
Fixes #263:
Summary of Problem:
There's no way to know if a characteristic has the specified CBCharacteristicWriteType when calling write because if it doesn't, success is returned instead of fail.
Proposed Solution:
In WriteCharacteristic
we check that the CBCharacteristic
has the passed type as a property, if it doesn't we fail the write.
Testing Completed and Required:
Calling write
with a mismatched CBCharacteristicWriteType
executes the fail
callback.
Thank you for submitting this pull request. This looks good to me, but I would like to also get our senior engineer to have a look as well. @nbrooke when you have time can you also review this PR? Thanks.
Any updates on this? @sakuraehikaru @nbrooke