qwindowkit icon indicating copy to clipboard operation
qwindowkit copied to clipboard

18px border between client area and right window edge

Open atraczyk opened this issue 1 year ago • 8 comments

image

Platform: seems to only occur on Windows 10 (22H2-19045.3803) and with ENABLE_WINDOWS_SYSTEM_BORDERS off Steps to reproduce:

  • I get it on application start with built-in and minimal examples

Note: resizing the app will correct the sizing issue, moving it again will reintroduce it.

Accepting the WM_MOVE event in WindowsNativeEventFilter::nativeEventFilter seems to prevent this from occurring, but I have no idea why or what side effects it introduces.

atraczyk avatar Jan 10 '24 15:01 atraczyk

I guess maybe there's something we didn't handle in WM_NCCALCSIZE handler. It may take some time to look into.

SineStriker avatar Jan 12 '24 13:01 SineStriker

Okay, thanks. Let me know if I can help by providing more information or test results.

atraczyk avatar Jan 12 '24 17:01 atraczyk

Thanks for using this library, it is a great honor that QWK could be used in such a grand project as JAMI. I'll investigate on a VM later.

SineStriker avatar Feb 24 '24 07:02 SineStriker

Since Qt 6.6.1, QTBUG-113736 has been fixed but the fixing patch conflicts with QWindowKit implementation, now I can only set the Qt::FramelessWindowHint to temporarily alleviate this inconsistency, I don't know if it will cause problems elsewhere.

SineStriker avatar Feb 24 '24 10:02 SineStriker

Qt 6.6.2 was released on Feb. 15, this issue has been fixed in the QTBUG-117704 patch, it is highly recommended that you use the newest release, as QWK's current workaround that adapts to 6.6.1 may introduce other issues.

SineStriker avatar Feb 24 '24 16:02 SineStriker

Thanks for using this library, it is a great honor that QWK could be used in such a grand project as JAMI. I'll investigate on a VM later.

Thanks for working on the library. It seems to require a profound knowledge of both the Qt framework and per-platform window management systems. The work is truly appreciated.

atraczyk avatar Feb 29 '24 19:02 atraczyk

Qt 6.6.2 was released on Feb. 15, this issue has been fixed in the QTBUG-117704 patch, it is highly recommended that you use the newest release, as QWK's current workaround that adapts to 6.6.1 may introduce other issues.

Okay, I will bump Qt and QWK and test on Windows ASAP. I'll report back.

atraczyk avatar Feb 29 '24 19:02 atraczyk

https://git.jami.net/savoirfairelinux/jami-client-qt/-/issues/1581

ovari avatar Mar 01 '24 07:03 ovari