stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C implementation for `math/base/special/spence`

Open Jordan-Gallivan opened this issue 2 years ago • 1 comments

Resolves #894

Description: C implementation of Spence's function

What is the purpose of this pull request?

This pull request:

  • C implementation of Spence's function

Related Issues

Does this pull request have any related issues? No.

This pull request:

  • resolves #894

Questions

Any questions for reviewers of this pull request?

o There was some inconsistency in the .js files in terms of referring to this as "Spence's Function" or the Dilogarithm". Would you like me to keep a standard naming convention through out? o while reasearching the evalpoly scripts, I noticed that some of the other functions that utilize cephes scripts do not have a c/native sub folder. I added one because the Ln() function does. I can easily delete it if it's not necessary o For the test.native.js, I again referenced Ln()/. Do that file goes from big numbers to small numbers, but the test.js in spence goes from small to big. Which would you prefer? o what commands do I need to execute to run the evalpoly script (to build in the polyval_a and polyval_b methods in the main.c file?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Jordan-Gallivan avatar Mar 07 '23 00:03 Jordan-Gallivan

Hey @Jordan-Gallivan, are you still working on this ? If not, can I take this up ?

gunjjoshi avatar Apr 01 '24 06:04 gunjjoshi