stdlib-js
bench: refactor to use dynamic memory allocation in 'blas/base/csrot'
Resolves #8643
Description
What is the purpose of this pull request?
This pull request:
- {{TODO: add description describing what this pull request does}}
Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
- #{{TODO: add related issue number}}
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [X] Read, understood, and followed the contributing guidelines.
AI Assistance
When authoring the changes proposed in this PR, did you use any kind of AI assistance?
- [X] Yes
- [ ] No
If you answered "yes" above, how did you use AI assistance?
- [ ] Code generation (e.g., when writing an implementation or fixing a bug)
- [ ] Test/benchmark generation
- [ ] Documentation (including examples)
- [ ] Research and understanding
Disclosure
If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| blas/base/csrot | $\color{green}418/418$ $\color{green}+0.00%$ |
$\color{green}17/17$ $\color{green}+0.00%$ |
$\color{green}4/4$ $\color{green}+0.00%$ |
$\color{green}418/418$ $\color{green}+0.00%$ |
The above coverage report was generated for the changes in this PR.
:warning: Tracking Issue Closure Warning :warning:
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".
Why this matters: Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.
Required action: Use "Progresses" instead to reference the tracking issue without automatically closing it.
Thank you for your contribution to the project!
@ishwarthecodddr update the PR tittle with:-
bench: refactor to use dynamic memory allocation in blas/base/csrot
add backtick( ` ) before and after the package name.
This PR contains artifacts from an improper Git merge. As such, I'll go ahead and close. Feel free to submit another PR which cleanly implements the changes.
