stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

[RFC]: Add C implementation for `@stdlib/math/base/special/spence`

Open Pranavchiku opened this issue 2 years ago • 9 comments

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/spence.

double stdlib_base_spence( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • [X] I have read and understood the Code of Conduct.
  • [X] Searched for existing issues and pull requests.
  • [X] The issue name begins with RFC:.

Pranavchiku avatar Feb 13 '23 06:02 Pranavchiku

I'd like to take this one on as well.

Jordan-Gallivan avatar Feb 28 '23 15:02 Jordan-Gallivan

Thanks, @Jordan-Gallivan, that would be great!

kgryte avatar Feb 28 '23 19:02 kgryte

@Jordan-Gallivan This implementation will be a touch more involved than your previous contributions.

You can use asin, as a reference. Namely, it will involve autogenerating some polynomial expressions, which requires a special comment syntax and running a script. However, instead of evalrational, you'll need to update evalpoly. You can consult other special math functions which have a C implementation and an evalpoly script.

Let us know if you have questions!

kgryte avatar Feb 28 '23 19:02 kgryte

Also, I'm happy to hop on a Google Meet to discuss further.

kgryte avatar Feb 28 '23 19:02 kgryte

@kgryte I definitely might need more coaching than the previous implementations but I think I'm up to the task. I'll comb through everything tonight and let you know if I have any questions before I jump in, in which case I'll definitely take you up on the Google Meet offer.

Jordan-Gallivan avatar Feb 28 '23 19:02 Jordan-Gallivan

Sounds good! Thanks for taking the initiative and working on this!

kgryte avatar Feb 28 '23 19:02 kgryte

@kgryte wanted to drop you a line and let you know that I'm still down to work this problem, I just got slammed last week with school/the internship search.

Jordan-Gallivan avatar Mar 05 '23 01:03 Jordan-Gallivan

@Jordan-Gallivan No worries!

kgryte avatar Mar 05 '23 01:03 kgryte

@kgryte just submitted a PR. You weren't kidding, this was a doozie. I added a few questions in the PR so please lemme know what I can fix.

Jordan-Gallivan avatar Mar 07 '23 00:03 Jordan-Gallivan