stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `ndarray/find-last`

Open headlessNode opened this issue 3 weeks ago • 1 comments

Resolves https://github.com/stdlib-js/metr-issue-tracker/issues/122.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/find-last

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves https://github.com/stdlib-js/metr-issue-tracker/issues/122
  • Progresses #2656

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • [ ] Yes
  • [x] No

If you answered "yes" above, how did you use AI assistance?

  • [ ] Code generation (e.g., when writing an implementation or fixing a bug)
  • [ ] Test/benchmark generation
  • [ ] Documentation (including examples)
  • [ ] Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

headlessNode avatar Dec 02 '25 20:12 headlessNode

Coverage Report

Package Statements Branches Functions Lines
ndarray/find-last $\color{green}381/381$
$\color{green}+0.00%$
$\color{green}46/46$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}381/381$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Dec 02 '25 20:12 stdlib-bot

/stdlib merge

kgryte avatar Dec 19 '25 10:12 kgryte

@headlessNode Remind me. Why is the option named sentinelValue rather than just sentinel?

kgryte avatar Dec 19 '25 10:12 kgryte

@kgryte no specific reason for it being sentinelValue rather than sentinel.

headlessNode avatar Dec 19 '25 11:12 headlessNode

2c: we should rename sentinelValue to sentinel here and in ndarray/find.

kgryte avatar Dec 19 '25 12:12 kgryte