[RFC]: add `symbol/search`
Description
This RFC proposes adding the package symbol/search.
The package should be very similar to the following existing packages:
symbol/has-instancesymbol/iteratorsymbol/async-iteratorsymbol/is-concat-spreadable
The primary difference is that the package should export Symbol.search if it exists.
Related Issues
None.
Questions
No.
Other
When adding this package, one should do the following:
- copy one of the existing packages mentioned above
- rename the copied package
- find and replace the package name (e.g.,
has-instance=>search) - find and replace the variable name (e.g.,
HasInstanceSymbol=>SearchSymbol) - ensure the copyright years are 2025
- update the descriptions according to the symbol's purpose (see MDN)
- update examples to reflect the symbol's purpose (see existing packages for inspiration)
- run tests, benchmarks, and examples to ensure that everything passes
- go back through and check that there are no copy-paste mistakes
Checklist
- [x] I have read and understood the Code of Conduct.
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with
RFC:.
:wave: Important: PLEASE READ :wave:
This issue has been labeled as a good first issue and is available for anyone to work on.
If this is your first time contributing to an open source project, some aspects of the development process may seem unusual, arcane, or some combination of both.
- You cannot "claim" issues. People new to open source often want to "claim" or be assigned an issue before beginning work. The typical rationale is that people want to avoid wasted work in the event that someone else ends up working the issue. However, this practice is not effective in open source, as it often leads to "issue squatting", in which an individual asks to be assigned, is granted their request, and then never ends up working on the issue. Accordingly, you are encouraged to communicate your intent to address this issue, ideally by providing a rough outline as to how you plan to address the issue or asking clarifying questions, but, at the end of the day, we will take running code and rough consensus in order to move forward quickly.
- We have a very high bar for contributions. We have very high standards for contributions and expect all contributions—whether new features, tests, or documentation—to be rigorous, thorough, and complete. Once a pull request is merged into stdlib, that contribution immediately becomes the collective responsibility of all maintainers of stdlib. When we merge code into stdlib, we are saying that we, the maintainers, commit to reviewing subsequent changes and making bugfixes to the code. Hence, in order to ensure future maintainability, this naturally leads to a higher standard of contribution.
Before working on this issue and opening a pull request, please read the project's contributing guidelines. These guidelines and the associated development guide provide important information, including links to stdlib's Code of Conduct, license policy, and steps for setting up your local development environment.
To reiterate, we strongly encourage you to refer to our contributing guides before beginning work on this issue. Failure to follow our guidelines significantly decreases the likelihood that you'll successfully contribute to stdlib and may result in automatic closure of a pull request without review.
Setting up your local development environment is a critical first step, as doing so ensures that automated development processes for linting, license verification, and unit testing can run prior to authoring commits and pushing changes. If you would prefer to avoid manual setup, we provide pre-configured development containers for use locally or in GitHub Codespaces.
We place a high value on consistency throughout the stdlib codebase. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.
- If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
- If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
- If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.
In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before beginning work on this issue.
:sparkles: Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. :sparkles:
Hi, can't find the file that we have to import from the assert folder, can someone please tell which file it is?
Hi @kgryte,
I'd like to work on this issue and request assignment. Here's my proposed approach:
Approach to solve [RFC]: add symbol/search:
-
Study existing symbol packages - Examine
symbol/has-instance,symbol/iteratorinlib/node_modules/@stdlib/symbol/ -
Copy template package - Use existing symbol package as template for consistency
-
Rename and update references:
- Rename package directory to
symbol/search - Update
package.jsonwith new name - Replace variable names:
HasInstanceSymbol->SearchSymbol - Update copyright year to 2025
- Rename package directory to
-
Update documentation:
- Modify README based on MDN
Symbol.search - Update JSDoc comments
- Update examples
- Modify README based on MDN
-
Testing & Validation:
- Run
npm test - Run
npm run examples - Verify
npm run lintpasses - Check for copy-paste errors
- Run
-
Submit PR with title: "feat: add symbol/search"
My background: Full-stack developer with experience in open source (Kibana, Rocket.Chat), strong JavaScript/TypeScript skills, familiar with stdlib patterns.
Thanks!