stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

[RFC]: Add C implementation for `@stdlib/math/base/special/rempio2`

Open Pranavchiku opened this issue 2 years ago • 9 comments

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/rempio2.

double stdlib_base_rempio2( const double x, double *y );

Related Issues

Related issues #735.

Questions

No.

Other

No.

Checklist

  • [X] I have read and understood the Code of Conduct.
  • [X] Searched for existing issues and pull requests.
  • [X] The issue name begins with RFC:.

Pranavchiku avatar Dec 26 '22 06:12 Pranavchiku

For reference, we could alternatively have the signature be

rempio2( const double x, double *y1, double *y2 );

Where y1 and y2 are pointers for storing output values. However, this is not conventional. Instead, FreeBSD expects a pointer to a two-element array. It is fine for us to do the same.

kgryte avatar Dec 27 '22 04:12 kgryte

Hello @kgryte @Pranavchiku I would like to work on this issue :)

lovelindhoni avatar Mar 03 '24 13:03 lovelindhoni

@lovelindhoni I'll prefer you to apply review and get #1659 merged.

Pranavchiku avatar Mar 03 '24 13:03 Pranavchiku

Also this PR depends on round.

Pranavchiku avatar Mar 03 '24 13:03 Pranavchiku

@Pranavchiku I think we can start working on this as the pkgs for this are already implemented in C

if it is fine can I take up this issue as I have completed the kernel rempio functions ?

USERSATOSHI avatar Mar 17 '24 10:03 USERSATOSHI

Also this PR depends on round.

~I only saw these pkg being used in rempio2~ found it in medium

high-word-abs-mask, high-word-exponent-mask, high-word-significand-mask, get-high-word, get-low-word, from-words

USERSATOSHI avatar Mar 17 '24 10:03 USERSATOSHI

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it, If possible, could you please let me know if there are any packages required for this? If you have been working on this too, please let me know! Best.

xaman27x avatar Mar 25 '24 17:03 xaman27x

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it, If possible, could you please let me know if there are any packages required for this? If you have been working on this too, please let me know! Best.

@xaman27x this package as of right now was not assigned as this is dependent on @stdlib/math/base/special/round which is right now in opened pull request state as requires review

and on my side , it is on hold until the c implementation of round is merged

USERSATOSHI avatar Mar 25 '24 18:03 USERSATOSHI

my bad it seems like the message repeated cause of poor network connection while i doubled clicked on comment as it wasn't sending

USERSATOSHI avatar Mar 25 '24 18:03 USERSATOSHI

This has now been implemented. Closing...

kgryte avatar Jul 27 '24 07:07 kgryte