stdlib-js
feat: add `array/float16`
progresses #7347 and #7273
Description
What is the purpose of this pull request?
This pull request:
- Adds array/float16 folder
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves #7273 #7347
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
This is the third PR. First two PRs are interconnected to each other. In order to merge this PR, we need to first merge PR 1: #7273 and #7347
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
Hello @Planeshifter and @kgryte sir,
With this PR, i have completed array/float16.
Please do review and merge PR along with two previously mentioned PRs.
So, i can start working on adding float16 datatype support for array/base, array/*, strided/8 and ndarray/*
@udaykakade25 Thank you for working on this. I left a few initial comments. The TL;DR is that the entire implementation needs to be reworked to be implemented in ES5. I strongly encourage you to emulate the style and approach used in
array/booland other custom array types implemented in stdlib.
Hello @kgryte sir, I have refactored the whole polyfill.js file that follows stdlib style. Thanks for reviewing!!
Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.
Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.
Hello @kgryte sir, I have changes that follow the standards below TABS Indentation ✅ Alphabetical Order ✅ Offset >>> 0 fix ✅ Readonly added ✅ Error formatting ✅ Utilities Added ✅ No Anonymous functions ✅ Missing Statistics Added ✅
Regarding failed CI checks:
Just Linting errors in Readme.md and Repl.txt are remaining to fix.
Rest other issues are encountered because the assert\has-float16array-support #7347 and assert/is-float16array #7273 PRs is still pending.
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| array/float16 | $\color{red}2728/2774$ $\color{green}+0.00%$ |
$\color{red}446/457$ $\color{green}+0.00%$ |
$\color{red}54/55$ $\color{green}+0.00%$ |
$\color{red}2728/2774$ $\color{green}+0.00%$ |
The above coverage report was generated for the changes in this PR.
I see that doctesting is failing due to missing Float16Array support. Will take a look.
I see that doctesting is failing due to missing
Float16Arraysupport. Will take a look.
Should I look into that?
Also if Float16Array doctesting support added lot of cleanup can be carried out by removing .get() from examples.