stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat!: migrate `utils/some-in-by` to `object/some-in-by`

Open Neerajpathak07 opened this issue 6 months ago • 3 comments

Resolves #7372.

Description

What is the purpose of this pull request?

This pull request:

  • migrates utils/some-in-by to object/some-in-by

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #7372

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Neerajpathak07 avatar Jun 16 '25 15:06 Neerajpathak07

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/alias2standalone $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/pkg2alias $\color{green}100/100$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2related $\color{green}100/100$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2standalone $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
namespace/standalone2pkg $\color{green}95/95$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}95/95$
$\color{green}+100.00\%$
object/some-in-by $\color{red}132/133$
$\color{green}+99.25\%$
$\color{red}13/14$
$\color{green}+92.86\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{red}132/133$
$\color{green}+99.25\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Jun 16 '25 15:06 stdlib-bot

@kgryte I have created a tracking a list to make the PR review easy for migration of some of the utils pkgs to object:-

  • [x] #6753
  • [ ] #6757
  • [x] #6759
  • [ ] #6805
  • [ ] #7375
  • [x] #7376

Neerajpathak07 avatar Jun 16 '25 15:06 Neerajpathak07

I believe there is an existing bug in some-in-by package similar coverage was also obtained in this PR:- #5745

Neerajpathak07 avatar Jun 16 '25 15:06 Neerajpathak07

Not a bug; just incomplete tests.

kgryte avatar Jun 26 '25 03:06 kgryte

@Neerajpathak07 In the future, you want to do these migrations one package at a time and not have multiple PRs; otherwise, merging one will cause merge conflicts in the others. I'll work through the current PRs, but we'll need to adopt a sequential approach to reduce review/merge overhead.

kgryte avatar Jun 26 '25 03:06 kgryte

@kgryte Understood, Will keep that in mind while working on other packages.

Neerajpathak07 avatar Jun 26 '25 12:06 Neerajpathak07