stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

fix: add javascript implementation for `/blas/base/dger`

Open ShabiShett07 opened this issue 9 months ago • 2 comments


type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Progresses #2039

Description

What is the purpose of this pull request?

This pull request:

  • There was a basic structure of /blas/base/dger which needed some update. I have added the Javascript implementation for it and improve the structure too.

Related Issues

Does this pull request have any related issues?

This pull request:

  • progresses #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

ShabiShett07 avatar Mar 26 '25 12:03 ShabiShett07

Coverage Report

Package Statements Branches Functions Lines
blas/base/dger $\color{green}715/715$
$\color{green}+100.00\%$
$\color{green}84/84$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}715/715$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Mar 26 '25 12:03 stdlib-bot

/stdlib update-copyright-years

ShabiShett07 avatar Mar 26 '25 13:03 ShabiShett07

/stdlib merge

ShabiShett07 avatar Jun 23 '25 08:06 ShabiShett07

/stdlib merge

@ShabiShett07, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

stdlib-bot avatar Jun 23 '25 08:06 stdlib-bot

@kgryte, I need your review on this, as it is a dependency for LAPACK packages too.

ShabiShett07 avatar Jun 23 '25 08:06 ShabiShett07

Also I am not sure about conflicts caused, because I have deleted the C and FORTRAN implementation, as we discussed in one of the office hours.

ShabiShett07 avatar Jun 23 '25 08:06 ShabiShett07

You can see the conflicts when you attempt to perform a local merge.

kgryte avatar Jun 23 '25 08:06 kgryte

@kgryte, I have solved the conflicts, ready for review

ShabiShett07 avatar Jun 23 '25 14:06 ShabiShett07

@kgryte, made a review and found some small changes which may be helpful

ShabiShett07 avatar Jun 25 '25 11:06 ShabiShett07

@kgryte, I have added seperate test cases and I think now it is good to go

ShabiShett07 avatar Jun 25 '25 12:06 ShabiShett07

@ShabiShett07 Your changes resulted in an incorrect test description and the tests should have been applied across the other test files. I have now addressed this.

kgryte avatar Jun 26 '25 00:06 kgryte

Sorry for that @kgryte , I was not sure about the test description, so my thought process was, instead of changing all the test files and generate structure error may be get feedback on one. But, finally, the most awaited PR got merged

ShabiShett07 avatar Jun 26 '25 02:06 ShabiShett07