stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `blas/ext/base/wasm/dnansumkbn2`

Open ShabiShett07 opened this issue 10 months ago • 12 comments


type: pre_push_report description: Results of running various checks prior to pushing changes. report:

  • task: run_javascript_examples status: na
  • task: run_c_examples status: na
  • task: run_cpp_examples status: na
  • task: run_javascript_readme_examples status: na
  • task: run_c_benchmarks status: na
  • task: run_cpp_benchmarks status: na
  • task: run_fortran_benchmarks status: na
  • task: run_javascript_benchmarks status: na
  • task: run_julia_benchmarks status: na
  • task: run_python_benchmarks status: na
  • task: run_r_benchmarks status: na
  • task: run_javascript_tests status: na ---

type: pre_push_report description: Results of running various checks prior to pushing changes. report:

  • task: run_javascript_examples status: na
  • task: run_c_examples status: na
  • task: run_cpp_examples status: na
  • task: run_javascript_readme_examples status: na
  • task: run_c_benchmarks status: na
  • task: run_cpp_benchmarks status: na
  • task: run_fortran_benchmarks status: na
  • task: run_javascript_benchmarks status: na
  • task: run_julia_benchmarks status: na
  • task: run_python_benchmarks status: na
  • task: run_r_benchmarks status: na
  • task: run_javascript_tests status: na ---

Resolves #5732

Description

What is the purpose of this pull request?

This pull request:

  • Solves #5732

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #5732

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

ShabiShett07 avatar Mar 02 '25 09:03 ShabiShett07

Hello! 👋

I've noticed that your commit doesn't contain the expected YAML metadata blocks. This typically happens when your development environment isn't properly set up with the stdlib git hooks.

Here's how to fix this:

  1. Install project dependencies (run this command in the top-level directory of the project):

    make install
    
  2. Initialize the development environment (this sets up the Git hooks among other things):

    make init
    

If you're still having issues, please check our development guide for more information.

Thank you for your contribution!

stdlib-bot avatar Mar 02 '25 09:03 stdlib-bot

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnansumkbn2 $\color{red}434/437$
$\color{green}+99.31\%$
$\color{red}38/39$
$\color{green}+97.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}434/437$
$\color{green}+99.31\%$
blas/ext/base/wasm/dnansumkbn2 $\color{green}551/551$
$\color{green}+100.00\%$
$\color{green}17/17$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}551/551$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Mar 02 '25 13:03 stdlib-bot

@0PrashantYadav0, may I know what was the changes needed because both the things look similar

ShabiShett07 avatar Apr 11 '25 10:04 ShabiShett07

In the docs you have ref to extend blas routines dnansumkbn2 but in preview it shows blas routines dnansumkbn2 which is not correct.

0PrashantYadav0 avatar Apr 11 '25 11:04 0PrashantYadav0

Comment : Please check your tests again.

0PrashantYadav0 avatar Apr 11 '25 11:04 0PrashantYadav0

@0PrashantYadav0, thank you for the corrections, I have made changes according to your suggestions

ShabiShett07 avatar Apr 12 '25 08:04 ShabiShett07

/stdlib merge

kgryte avatar Apr 22 '25 18:04 kgryte

/stdlib merge

kgryte avatar May 14 '25 20:05 kgryte

@kgryte, I have added Float64Array in both index.d.ts and index.js

ShabiShett07 avatar May 16 '25 04:05 ShabiShett07

@kgryte, I have made the required changes.

ShabiShett07 avatar May 16 '25 10:05 ShabiShett07

/stdlib merge

ShabiShett07 avatar Jun 01 '25 08:06 ShabiShett07

@kgryte, I have tried to find all mistakes and resolved them. Also I have updated the implementation according to the updated package

ShabiShett07 avatar Jun 01 '25 09:06 ShabiShett07