stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `blas/base/icamax`

Open ShabiShett07 opened this issue 11 months ago • 12 comments

Progresses #2039

Description

What is the purpose of this pull request?

This pull request:

  • includes the support for Javascript and obtains Fortran reference from this page

Related Issues

Does this pull request have any related issues?

This pull request:

  • progresses #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

ShabiShett07 avatar Feb 05 '25 19:02 ShabiShett07

Coverage Report

Package Statements Branches Functions Lines
blas/base/icamax $\color{green}230/230$
$color{green}+100.00%$
$\color{green}15/15$
$color{green}+100.00%$
$\color{green}2/2$
$color{green}+100.00%$
$\color{green}230/230$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Feb 11 '25 16:02 stdlib-bot

/stdlib lint-autofix

ShabiShett07 avatar Feb 11 '25 17:02 ShabiShett07

/stdlib update-copyright-years

ShabiShett07 avatar Feb 11 '25 17:02 ShabiShett07

@kgryte, Please do review this!

ShabiShett07 avatar Feb 11 '25 18:02 ShabiShett07

/stdlib merge

aman-095 avatar Feb 19 '25 05:02 aman-095

/stdlib update-copyright-years

aman-095 avatar Feb 19 '25 05:02 aman-095

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

aman-095 avatar Feb 19 '25 06:02 aman-095

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

Thank you Aman sir for making the necessary changes in this PR.

May I know is this PR ready for merge?

ShabiShett07 avatar Feb 19 '25 08:02 ShabiShett07

Hello @aman-095 sir, thank you for suggesting the changes and made the necessary changes. Please do check.

ShabiShett07 avatar Feb 20 '25 17:02 ShabiShett07

cc: @kgryte @Planeshifter

ShabiShett07 avatar Apr 12 '25 19:04 ShabiShett07

/stdlib merge

kgryte avatar Apr 22 '25 17:04 kgryte

/stdlib merge

ShabiShett07 avatar Jun 13 '25 08:06 ShabiShett07

@kgryte, made some clean-up which I found, need your review

ShabiShett07 avatar Jun 27 '25 07:06 ShabiShett07

@ShabiShett07, before resolving any comment make sure the change is incorporated incase of any issues mention there itself. It helps later reviewing the PR again.

aman-095 avatar Jul 17 '25 05:07 aman-095

@aman-095, sorry for that mistake, I have checked the changes I made now, need your review

ShabiShett07 avatar Jul 18 '25 06:07 ShabiShett07

/stdlib merge

kgryte avatar Sep 02 '25 07:09 kgryte

/stdlib merge

kgryte avatar Nov 19 '25 05:11 kgryte