feat: add C ndarray API and refactor for `stats/base/sdsnanmean`
type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:
- task: lint_filenames status: passed
- task: lint_editorconfig status: passed
- task: lint_markdown status: passed
- task: lint_package_json status: na
- task: lint_repl_help status: na
- task: lint_javascript_src status: passed
- task: lint_javascript_cli status: na
- task: lint_javascript_examples status: passed
- task: lint_javascript_tests status: passed
- task: lint_javascript_benchmarks status: passed
- task: lint_python status: na
- task: lint_r status: na
- task: lint_c_src status: passed
- task: lint_c_examples status: passed
- task: lint_c_benchmarks status: passed
- task: lint_c_tests_fixtures status: na
- task: lint_shell status: na
- task: lint_typescript_declarations status: na
- task: lint_typescript_tests status: na
- task: lint_license_headers status: passed ---
type: pre_push_report description: Results of running various checks prior to pushing changes. report:
- task: run_javascript_examples status: na
- task: run_c_examples status: na
- task: run_cpp_examples status: na
- task: run_javascript_readme_examples status: na
- task: run_c_benchmarks status: na
- task: run_cpp_benchmarks status: na
- task: run_fortran_benchmarks status: na
- task: run_javascript_benchmarks status: na
- task: run_julia_benchmarks status: na
- task: run_python_benchmarks status: na
- task: run_r_benchmarks status: na
- task: run_javascript_tests status: na ---
Resolves None
Description
What is the purpose of this pull request?
This pull request:
- Adds C ndarray implementation for
stats/base/sdsnanmean - Refactors
stats/base/sdsnanmean - Adds C implementation section in README.md.
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves None
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
/stdlib merge
/stdlib merge
/stdlib merge
@0PrashantYadav0 Should this PR be closed out?
/stdlib-merge
/stdlib-merge
@0PrashantYadav0, slash command not recognized. Please use /stdlib help to view available commands.
/stdlib merge
@kgryte This pr depend on Pull-4727. So we have to wait for pr-4727 to merge before opening this.
@gururaj1512 Why we updated rand_double to rand_float.
@gururaj1512 Why we updated
rand_doubletorand_float.
We generate array of single precision random numbers in single precision packages.
@gururaj151 Sorry, I just got a little confused there.
/stdlib merge
@0PrashantYadav0 Mind addressing the CI failures in this PR?
Sure
Coverage Report
| Package | Statements | Branches | Functions | Lines |
|---|---|---|---|---|
| stats/base/sdsnanmean | $\color{green}345/345$ $\color{green}+100.00\%$ |
$\color{green}13/13$ $\color{green}+100.00\%$ |
$\color{green}4/4$ $\color{green}+100.00\%$ |
$\color{green}345/345$ $\color{green}+100.00\%$ |
The above coverage report was generated for the changes in this PR.