stdlib
stdlib copied to clipboard
stdlib-js
Add sind implementation
Resolves #32
Description
What is the purpose of this pull request?
This pull request:
- implements sind using kernel sin and kernel cos
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves #32
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
@AlisaLC You mind checking the box above to indicate that you've read the contributing guidelines? In particular, checking this box means agreeing to the licensing terms.
Done. but if i remember correctly, a few of the tests didn't pass by narrow margins which were normal sin tests but for some reason kernel sin was not as accurate!
@AlisaLC Thanks! Yeah, kernel sine is sensitive to argument scaling. I'll take a look.