stdlib-js
feat: add `math/base/special/acosdf`
Resolves part of #649.
Description
What is the purpose of this pull request?
This pull request:
- Resolves a part of #649 by adding the C implementation for
math/base/special/acosdf.
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves part of #649
Questions
Any questions for reviewers of this pull request?
Open to reviews!!
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
@gunjjoshi would love your inputs on this, is it okay if i had to increase the tolerance in the tests a bit to accommodate single-precision floating point numbers?
@gunjjoshi would love your inputs on this, is it okay if i had to increase the tolerance in the tests a bit to accommodate single-precision floating point numbers?
I think the tolerance levels that we have here, i.e., 2.8 * EPS should be fine, as compared to the 1.4 * EPS of the double-precision equivalent, as we can expect a slight precision loss when we transition from double to single-precision floating-point numbers.
that's what i thought while increasing the tolerance, do you think there's any other stuff that needs to be done in order to merge this @gunjjoshi , would love to work on this
I've made all the required changes from code review, thank you for your time @gunjjoshi , @kgryte .
is there anything that is left to do here @gunjjoshi ? , would be happy to implement
PR Commit Message
feat: add `math/base/special/acosdf`
PR-URL: https://github.com/stdlib-js/stdlib/pull/3015
Ref: https://github.com/stdlib-js/stdlib/issues/649
Co-authored-by: Athan Reines <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Please review the above commit message and make any necessary adjustments.
