stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C `ndarray` API and refactor `blas/ext/base/dnansumkbn`

Open headlessNode opened this issue 1 year ago • 2 comments

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Add sC ndarray API and refactor/cleanup blas/ext/base/dnansumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

headlessNode avatar Oct 09 '24 12:10 headlessNode

@headlessNode The downstream test failure is expected in this PR?

kgryte avatar Oct 19 '24 09:10 kgryte

@kgryte Yes, the dnansum uses dnansumkbn for computing the sum. Should be fixed when dnansum is refactored.

headlessNode avatar Oct 19 '24 09:10 headlessNode

Will merge shortly.

Failing CI checks are due to a) cppcheck errors and b) dnansum unit test being in need of updating due to the equivalent PR of this one for dnansumors, which also changed the behavior for a stride of zero.

Planeshifter avatar Oct 30 '24 00:10 Planeshifter

PR Commit Message

feat: add C `ndarray` API and refactor `blas/ext/base/dnansumkbn`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2996

Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>

Please review the above commit message and make any necessary adjustments.

stdlib-bot avatar Oct 30 '24 00:10 stdlib-bot