stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C `ndarray` API and refactor `blas/ext/base/dnannsumkbn`

Open headlessNode opened this issue 1 year ago • 2 comments

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnannsumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

headlessNode avatar Oct 05 '24 15:10 headlessNode

The failing test is from dnannsum which uses dnannsumkbn to compute the sum. It will be resolved once dnannsum is refactored.

headlessNode avatar Oct 05 '24 15:10 headlessNode

@kgryte Using CBLAS_INT is causing the format specifier error. I think we will need to define format specifiers for CBLAS_INT.

EDIT: Just saw that it is defined. Sorry for the oversight.

headlessNode avatar Oct 06 '24 09:10 headlessNode

@headlessNode Based on feedback in the other PRs, does this PR need some further tweaks?

kgryte avatar Nov 17 '24 22:11 kgryte

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dnannsumkbn $\color{green}491/491$
$\color{green}+100.00\%$
$\color{green}42/42$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}491/491$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Nov 18 '24 10:11 stdlib-bot

@kgryte ready for review.

headlessNode avatar Nov 18 '24 11:11 headlessNode

@headlessNode This PR has a failing test atm.

kgryte avatar Nov 19 '24 04:11 kgryte

@kgryte the failing test is expected.

headlessNode avatar Nov 19 '24 07:11 headlessNode

Ah, right. It is a downstream test suite which is failing.

kgryte avatar Nov 19 '24 07:11 kgryte

As mentioned in https://github.com/stdlib-js/stdlib/pull/2988#issuecomment-2484947084, the CI test failure in the downstream library is expected. This failure will be resolved in a subsequent PR/commit. As such, I will go ahead and merge.

kgryte avatar Nov 20 '24 00:11 kgryte