stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `blas/base/sger`

Open aman-095 opened this issue 1 year ago • 5 comments

Progresses #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to the rank 1 operation A = α*x*y^T + A, where α is a scalar, x is an M element vector, y is an N element vector and A is an M by N matrix as defined in BLAS Level 2 routines. Specifically adding @stdlib/blas/base/sger is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

  • progresses #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

aman-095 avatar Aug 08 '24 12:08 aman-095

Coverage Report

Package Statements Branches Functions Lines
blas/base/sger $\color{green}715/715$
$\color{green}+100.00\%$
$\color{green}84/84$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}715/715$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

stdlib-bot avatar Jun 12 '25 17:06 stdlib-bot

/stdlib update-copyright-years

ShabiShett07 avatar Jun 13 '25 04:06 ShabiShett07

/stdlib merge

ShabiShett07 avatar Jun 13 '25 04:06 ShabiShett07

/stdlib merge

@ShabiShett07, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

stdlib-bot avatar Jun 13 '25 04:06 stdlib-bot

/stdlib merge

ShabiShett07 avatar Jun 13 '25 05:06 ShabiShett07

/stdlib update-copyright-years

ShabiShett07 avatar Jun 27 '25 06:06 ShabiShett07

@kgryte, I have made a review from my side, need a review from you on this

ShabiShett07 avatar Jun 27 '25 06:06 ShabiShett07

/stdlib merge

kgryte avatar Jun 28 '25 11:06 kgryte

@ShabiShett07 Would you mind going ahead and adding the C and Fortran implementation, along with the associated benchmarks, tests, and examples? We might as well go ahead and get everything in one PR since dger already shows the path forward.

kgryte avatar Jun 29 '25 10:06 kgryte

/stdlib update-copyright-years

ShabiShett07 avatar Jul 01 '25 08:07 ShabiShett07

/stdlib merge

ShabiShett07 avatar Jul 01 '25 08:07 ShabiShett07

/stdlib update-copyright-years

ShabiShett07 avatar Jul 01 '25 10:07 ShabiShett07

@kgryte, not sure why sger.native.js is not working as expected

ShabiShett07 avatar Jul 01 '25 11:07 ShabiShett07

@kgryte, I think this is ready for the review

ShabiShett07 avatar Jul 01 '25 18:07 ShabiShett07