stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard
verified publisher icon stdlib-js

feat: add `lapack/base/dlange`

Open Pranavchiku opened this issue 1 year ago • 4 comments

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dlange

Related Issues

Does this pull request have any related issues?

Towards #2464

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • [x] Read, understood, and followed the contributing guidelines.
  • [x] Add tests to test correct value of Forbenius Norm.
  • [x] cleanup base implementation.
  • [x] refactor implementation following dlacpy.

@stdlib-js/reviewers

Pranavchiku avatar Jul 29 '24 16:07 Pranavchiku

There are a few improvements we can make in this PR, post / in our meet today:

  • [ ] replace j,i with i0, i1
  • [x] check correctness of comments in base implementation
  • [x] Add an access variable ( functioning same as dim )

Pranavchiku avatar Jul 31 '24 13:07 Pranavchiku

@kgryte can we please do implementation of access variable in subsequent PRs? This is a major change, I'll prefer to do it in another PR, please.

Pranavchiku avatar Aug 02 '24 14:08 Pranavchiku

@Pranavchiku I am not sure the benefit of doing in a follow-up PR. And also, s/access/axis/.

kgryte avatar Aug 02 '24 16:08 kgryte

Done, this PR can have a review now :))

Pranavchiku avatar Aug 03 '24 10:08 Pranavchiku

This PR has been superseded by https://github.com/stdlib-js/stdlib/pull/7195

kgryte avatar Jul 11 '25 10:07 kgryte