stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `blas/base/dtrsm`

Open Pranavchiku opened this issue 1 year ago • 5 comments

Description

What is the purpose of this pull request?

This pull request adds JS implementation for blas/base/dtrsm ( Level: 3 ). Towards #2464.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

There will be lint errors. I'll polish it once I add other files. I wish that this PR have an initial review to see if direction is correct.

netlib-dtrsm

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

TODO:

  • [x] Either remove fixtures or rename fixture name
  • [x] refactor base implementation to compute general offset outside loop
  • [x] add tests for negative strides
  • [x] update test description
  • [x] fix replt lint error

Checklist

  • [x] Add readme.md
  • [x] Add package.json
  • [x] Add lib
  • [x] Add examples
  • [x] Add ndarray implementation
  • [x] Add docs
  • [x] Add benchmark
  • [x] Add test
  • [x] Refactor implementation

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Pranavchiku avatar Jul 06 '24 06:07 Pranavchiku

It's been a while I used symbolab

Pranavchiku avatar Jul 08 '24 06:07 Pranavchiku

A generalisation that I observed while adding examples, row-major upper is column-major upper transpose so, just implement column-major and for row-major, do a transpose that is change transA variable.

Pranavchiku avatar Jul 08 '24 06:07 Pranavchiku

I think we have initial implementation in, although this PR needs to be polished before anyone reviews this. I'll now refactor implementation to decrease nested looping and simplify source code.

Pranavchiku avatar Jul 08 '24 08:07 Pranavchiku

I think this PR can have a review.

Pranavchiku avatar Jul 25 '24 15:07 Pranavchiku

@Pranavchiku This PR needs to be updated to remove the order argument from the ndarray method. Also, probably worthwhile looking at the recently merged dtrmv package regarding emerging conventions around descriptions, etc.

kgryte avatar Aug 01 '24 21:08 kgryte

Closing this PR as working on it in PR #7359

ShabiShett07 avatar Jul 04 '25 07:07 ShabiShett07